[ic] Was: Interchange 4.8.4 now available

[interchange-users@interchange.redhat.com (Jon Jensen)]

On 2 May 2002, Stefan Hornburg (Racke) wrote:

> The key might be a missing From:-Header. Looks like mail_order doesn't set
> it, but the email tag does it. Anyone here with sendmail installed who
> would like to look further into it ?

In Vend::Order::mail_order:

$email = $Vend::Cfg->{MailOrderTo} unless $email;
[...]
$ok = send_mail($email, $subject, $body);

In Vend::Util::send_mail:

sub send_mail {
    my($to, $subject, $body, $reply, $use_mime, @extra_headers) = @_;
[...]
        open(MVMAIL,"|$Vend::Cfg->{SendMailProgram} -t") or last SEND;
[...]
        print MVMAIL "To: $to\n", $reply, "Subject: $subject\n"
            or last SEND;

(That excerpt from Vend::Util::send_mail is after my patch adding -t.)  

Every other call to /usr/lib/sendmail uses the -t option to pass the
address in the headers, but this routine used to supply it on the command
line. I think we just missed this during testing somehow.

Jon