[ic] please fix this !

[Murray Gibbins <Murray@scotweb.ltd.uk>]

Every time I upgrade interchange/minivend I have to hack about inside the code
making patches because of some silly inbuilt limitations. 

Please,please,please can something be done about the limits on CommonAdjust
string/atoms.

To illustrate here is my common adjust string ( with the shop names replaced).

CommonAdjust	shop1:price:, shop2:price:, shop3:price:, shop4:price:,
shop5:price:, shop6:price:, shop7:price:, shop8:price:, shop9:price:,
shop10:price:, shop11:price:, shop12:price:, shop13:price:, 
==material:shop12_pricing::, ==size:shop12_pricing::, 
==trewbottom:shop11_pricing::, ==pcwaist:shop11_pricing::,
==gkheight:shop11_pricing::, ==waistcut:shop11_pricing::,
==trewfly:shop11_pricing::, ==colour:shop11_pricing::,
==trewrsidepock:shop11_pricing::, ==pclength:shop11_pricing::,
==size:shop11_pricing::, ==pcsleeve:shop11_pricing::,
==jacketcuff:shop11_pricing::, ==trim:shop11_pricing::,
==trewwaisttype:shop11_pricing::, ==trewinsleg:shop11_pricing::,
==buckle:shop11_pricing::, ==pcheight:shop11_pricing::,
==tawaist:shop11_pricing::, ==pcchestact:shop11_pricing::,
==gkwaist:shop11_pricing::, ==trewlsidepock:shop11_pricing::,
==chainstrap:shop11_pricing::, ==lkwaist:shop11_pricing::,
==trewheight:shop11_pricing::, ==pcchestpeg:shop11_pricing::,
==trewseat:shop11_pricing::, ==trewoutleg:shop11_pricing::,
==talength:shop11_pricing::, ==tasleeve:shop11_pricing::,
==lkseat:shop11_pricing::, ==tartan:shop11_pricing::, ==gkseat:shop11_pricing::,
==design:shop11_pricing::, ==taheight:shop11_pricing::,
==material:shop11_pricing::, ==trewrhippock:shop11_pricing::,
==tachestact:shop11_pricing::, ==lkheight:shop11_pricing::,
==flashes:shop11_pricing::, ==belt:shop11_pricing::,
==tachestpeg:shop11_pricing::, ==length:shop11_pricing::,
==buttons:shop11_pricing::, ==trewloop:shop11_pricing::,
==collar:shop11_pricing::, ==collarsize:shop11_pricing::,
==trewlhippock:shop11_pricing::, ==trewwaist:shop11_pricing::,
==gklength:shop11_pricing::, ==shoesize:shop11_pricing::, 
==style:shop10_pricing::, ==colour:shop10_pricing::,
==material:shop10_pricing::,  ==colours:shop9_pricing::,
==sizes:shop9_pricing::,  ==thething:shop6_pricing::,
==showname:shop6_pricing::, ==thename2:shop6_pricing::,
==supports:shop6_pricing::, ==thename:shop6_pricing::, 
==format:shop5_pricing::, ==design:shop5_pricing::,  ==material:shop3_pricing::,
==stone:shop3_pricing::,  ==pattern:shop2_pricing::, ==sole:shop2_pricing::,
==stdordual:shop2_pricing::, ==format:shop2_pricing::,
==special:shop2_pricing::, ==colour:shop2_pricing::, ==player:shop2_pricing::,
==material:shop2_pricing::, ==size:shop2_pricing::, ==key:shop2_pricing::

Otherwise I'm going to have to write my own CommonAdjust server and just put in
calls to it from the commonadjust string like I had to do for shipping, because
I KEEP HAVING TO CHANGE Data.pm , gerr-arg!

"7. Release early. Release often. And listen to your customers"

================================

Also while I'm on the subject in Data::chain_cost

snip--------------------

if($raw =~ /^\[\B/ and $raw =~ /\]$/) {


--------------------/snip

is meant to catch interchange "[]" statements? if so why "[\B", '\B' is "not
word boundary"? Even if you keep the word boundary how about....

if($raw =~ /^\[\B.*\]$/o) {

as a more compact regex !

or even ...

if($raw =~ /^\[\B.+\]$/o) {

"13. ``Perfection (in design) is achieved not when there is nothing more to add,
but rather when there is nothing more to take away.''"

God I would sooooo like to rewrite the chain_cost subroutine, please :-)


Yours

Murray

"2. Good programmers know what to write. Great ones know what to rewrite (and
reuse)."


-- 
  ____
  \__/    Murray Gibbins             murray@scotweb.ltd.uk
  /  \    Programmer
_ \__/ _  ================================================
\\ || //  Scotweb Limited,             info@scotweb.ltd.uk
 \\||//   13a Albert Terrace,    http://www.scotweb.ltd.uk
  \||/    Edinburgh EH10 5EA   Tel: +44 (0)  131 270 82 33
   ||     Scotland. Europe.    Fax: +44 (0) 7020  93 49 04

_______________________________________________
Interchange-users mailing list
Interchange-users@lists.akopia.com
http://lists.akopia.com/mailman/listinfo/interchange-users