Re: RPM spec

[Matthew Rice <matt@starnix.com>]

Mike,

Thanks a lot for making this rpm.

Just a couple of comments (one is actually useful <g>):

<PEDANTIC>
> Source:    minivend-3.14.tar.gz

I think that generally you should put the full path to the download.  eg.
  Source: ftp://ftp.minivend.com/pub/%{packagename}-%{packageversion}.tar.gz

	
> Copyright: GNU General Public License
> BuildRoot: /var/tmp/minivend-3.14

And use /var/tmp/%{packagename}-%{packageversion}
Just less to change.


> %postun
> /etc/rc.d/init.d/minivend stop
> if [ $1 = 0 ] ; then
> 	userdel minivend >/dev/null 2>&1 || :
> 	rm -f /etc/rc.d/rc*.d/*minivend
> fi

Perhaps this should be broken up into a {pre,post}un:
%preun
/etc/rc.d/init.d/minivend stop;# Could this hang?
/sbin/chkconfig --del minivend

%postun
userdel minivend >/dev/null 2>&1 || :

> %file

You could specify the permissions for the files here (rpm --verify would
like it better) to make make the '%post' simpler but I'll take what I can
get.  Thanks again.
</PEDANTIC>
-- 
matthew rice <matt@starnix.com>                               starnix inc.
tollfree: 1-87-pro-linux                         brampton, ontario, canada
http://www.starnix.com              professional linux services & products