FIX: Error: &final=no, but mv_successpage is set

["Alan Sparks" <asparks@nss.harris.com>]

******    message to minivend-users from "Alan Sparks" <asparks@nss.harris.com>     ******

I do indeed think this is a bug, and I've fixed it to work properly on my
install of MV 3.11.  The problem is that the global vars $Fatal and $Final
are being set appropriately, but the value of the _final and _fatal subs
should not be anything other than true.

To apply the fix, change lines 59-68 of lib/Vend/Order.pm to look as follows
(note the addition of the true return value):

sub _fatal {
        $Fatal = ( defined($_[1]) && ($_[1] =~ /^[yYtT1]/) ) ? 1 : 0;
        1;  # ADD THIS
}

sub _final {
        $Final = ( defined($_[1]) && ($_[1] =~ /^[yYtT1]/) ) ? 1 : 0;
        1;  # ADD THIS
}

Remember to restart the server after the change.

After this, &final and &fatal do behave as documented, and can be located at
the top or bottom or sideways in the order profile.

-Alan


-----Original Message-----
From: Alan Sparks <asparks@nss.harris.com>
To: minivend-users@minivend.com <minivend-users@minivend.com>
Date: Wednesday, March 03, 1999 11:48 AM
Subject: Re: Error: &final=no, but mv_successpage is set


>******    message to minivend-users from "Alan Sparks"
<asparks@nss.harris.com>     ******
>
>Did a solution for this problem come up?  I too am seeing the same behavior
>and cannot find the fix.  I've also put &final=no at the top of the
profile,
>and set mv_successpage, but get the Error: &final=no result.
>
>Incidentally, is this the right way to do it?
>&final=no
>&set=mv_successpage ord/checkout2
>
>Thanks.
>-Alan
>
>
>-----Original Message-----
>From: Gerard Olszowiec <gerard@entitysoftware.com>
>To: Minivend Maillist <Minivend-users@minivend.com>
>Date: Tuesday, March 02, 1999 11:30 AM
>Subject: Re: Error: &final=no, but mv_successpage is set
>
>
>>******    message to minivend-users from "Gerard Olszowiec"
><gerard@entitysoftware.com>     ******
>>
>>-----Original Message-----
>>From: mikeh@minivend.com <mikeh@minivend.com>
>>To: Gerard Olszowiec <gerard@entitysoftware.com>
>>Date: Tuesday, March 02, 1999 1:54 PM
>>Subject: Re: Error: &final=no, but mv_successpage is set
>>
>>
>>>Don't make it the last line, make it the first. I will add it
>>>to the docs todo list. (Must have a true value as the last line
>>>to succeeed.)
>>
>>
>>I must be a bit dense Mike, I moved the &final=no from the last line, but
I
>>still get 'Error: &final=no'.  (See below.)  I am assuming when you said
>>'make it the first' you didn't mean to move it up after [set
>>checkout_profile]'?  In any event I also tried that and the same error.
>>
>>[set checkout_profile]
>>&fatal=yes
>>[if value email]
>>email=email
>>&set = mv_email [value email]
>>[/if]
>>[if value credit_card_number]
>>&set = mv_credit_card_number [value credit_card_number]
>>mv_credit_card_number=required
>>[/if]
>>
>>&set = order_date [tag time]%m/%d/%Y[/tag]
>>&set = order_time [tag time]%H:%M:%S[/tag]
>>&set = order_datetime [tag time]%b %d, %Y  %I:%M%p[/tag]
>>&set = mv_payment Credit Card ([default mv_credit_card_type])
>>
>>&final=no
>>&set = mv_successpage ord/checkout2
>>[/set]
>>
>>Cheers,
>>Gerard
>>------------------------------
>>Gerard Olszowiec
>>Entity Software
>>gerard@entitysoftware.com
>>www.entitysoftware.com
>>
>>
>>
>>-
>>To unsubscribe from the list, DO NOT REPLY to this message.  Instead, send
>>email with 'UNSUBSCRIBE minivend-users' in the body to
>Majordomo@minivend.com.
>>Archive of past messages: http://www.minivend.com/minivend/minivend-list
>
>-
>To unsubscribe from the list, DO NOT REPLY to this message.  Instead, send
>email with 'UNSUBSCRIBE minivend-users' in the body to
Majordomo@minivend.com.
>Archive of past messages: http://www.minivend.com/minivend/minivend-list

-
To unsubscribe from the list, DO NOT REPLY to this message.  Instead, send
email with 'UNSUBSCRIBE minivend-users' in the body to Majordomo@minivend.com.
Archive of past messages: http://www.minivend.com/minivend/minivend-list