Re: Error: &final=no, but mv_successpage is set -- BUG?!

["Alan Sparks" <asparks@nss.harris.com>]

******    message to minivend-users from "Alan Sparks" <asparks@nss.harris.com>     ******

I've been looking at the code for this, and it just looks wrong...  The
sequence between lines 574 and 610, in Vend::Order:

How is this sequence going to _not_ flag the order as incomplete?  If
&final=no, it flags a check error.  Isn't this a bug???

                $parameter = $_;
                if (/^&/) {
                        ($var,$val) = split /[\s=]+/, $parameter, 2;
                }
....
                if (defined $Parse{$var}) {
                        ($val, $var, $message) = &{$Parse{$var}}($ref,
$val);
                }
....
                unless (defined $val and $val) {
                        $status = 0;
                        if (defined $var) {

$Vend::Session->{'values'}->{"mv_error_$var"} = $message;
                                push @Errors, "$var: $message";
                        }
                        else {
                                push @Errors, "Error: $parameter";
                        }
                }


-----Original Message-----
From: Gerard Olszowiec <gerard@entitysoftware.com>
To: Minivend Maillist <Minivend-users@minivend.com>
Date: Tuesday, March 02, 1999 11:30 AM
Subject: Re: Error: &final=no, but mv_successpage is set


>******    message to minivend-users from "Gerard Olszowiec"
<gerard@entitysoftware.com>     ******
>
>-----Original Message-----
>From: mikeh@minivend.com <mikeh@minivend.com>
>To: Gerard Olszowiec <gerard@entitysoftware.com>
>Date: Tuesday, March 02, 1999 1:54 PM
>Subject: Re: Error: &final=no, but mv_successpage is set
>
>
>>Don't make it the last line, make it the first. I will add it
>>to the docs todo list. (Must have a true value as the last line
>>to succeeed.)
>
>
>I must be a bit dense Mike, I moved the &final=no from the last line, but I
>still get 'Error: &final=no'.  (See below.)  I am assuming when you said
>'make it the first' you didn't mean to move it up after [set
>checkout_profile]'?  In any event I also tried that and the same error.
>
>[set checkout_profile]
>&fatal=yes
>[if value email]
>email=email
>&set = mv_email [value email]
>[/if]
>[if value credit_card_number]
>&set = mv_credit_card_number [value credit_card_number]
>mv_credit_card_number=required
>[/if]
>
>&set = order_date [tag time]%m/%d/%Y[/tag]
>&set = order_time [tag time]%H:%M:%S[/tag]
>&set = order_datetime [tag time]%b %d, %Y  %I:%M%p[/tag]
>&set = mv_payment Credit Card ([default mv_credit_card_type])
>
>&final=no
>&set = mv_successpage ord/checkout2
>[/set]
>
>Cheers,
>Gerard
>------------------------------
>Gerard Olszowiec
>Entity Software
>gerard@entitysoftware.com
>www.entitysoftware.com
>
>
>
>-
>To unsubscribe from the list, DO NOT REPLY to this message.  Instead, send
>email with 'UNSUBSCRIBE minivend-users' in the body to
Majordomo@minivend.com.
>Archive of past messages: http://www.minivend.com/minivend/minivend-list

-
To unsubscribe from the list, DO NOT REPLY to this message.  Instead, send
email with 'UNSUBSCRIBE minivend-users' in the body to Majordomo@minivend.com.
Archive of past messages: http://www.minivend.com/minivend/minivend-list